[test] fix: register internal pytest marker#4359
Merged
Merged
Conversation
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
/ok to test 9397e03 |
Signed-off-by: Yu Yao <yaoyu.094@gmail.com>
yaoyu-33
force-pushed
the
yuya/mcore-main-autofix-20260615-pr4357
branch
from
9397e03 to
8565d45
Compare
Contributor
Author
|
/ok to test 8565d45 |
Contributor
Light Code ReviewSummary: Registers the internal pytest marker that was missing from pyproject.toml, fixing --strict-markers collection failures in CI. Also bumps MCore submodule and regenerates the lockfile. The fix is correct and minimal. The @pytest.mark.internal usage in tests/unit_tests/models/qwen_vl/modelling_qwen3_vl/test_attention.py:129 is the only site using this marker, and the new registration in pyproject.toml resolves the strict-markers error. No issues found. Minor observations (non-blocking):
Suggested test cases: No perf tests impacted. |
yaoyu-33
added
area:ci
ci
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test 09511e3 |
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test f706d1d |
Contributor
Author
|
/ok to test 6e553da |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main / mcore-mainautomated bump PR chore(beep boop 🤖): Bumpuv.lock(main, mcore-main) (2026-06-15) #4357 by registering the existinginternalpytest marker.Original bump PR: #4357
Target:
mainFailure classification: Bridge broke itself
Root Cause
Launch_Unit_Tests_Corecollectedtests/unit_tests/models/qwen_vl/modelling_qwen3_vl/test_attention.py, which uses@pytest.mark.internal. The project runs pytest with--strict-markers, butpyproject.tomldid not registerinternal, so collection failed before MCore-specific coverage ran.Fix
internalto[tool.pytest.ini_options].markers.Guards
None added or removed.
Validation
uvx --from pytest==9.1.0 pytest -c /tmp/mb_pyproject_before_4357.toml --override-ini addopts=--strict-markers /tmp/mb_internal_marker_repro.py --collect-only -q: failed before the fix withinternalmissing.uvx --from pytest==9.1.0 pytest -c pyproject.toml --override-ini addopts=--strict-markers /tmp/mb_internal_marker_repro.py --collect-only -q: passed after the fix,1 test collected.uv run python -m pytest tests/unit_tests/models/qwen_vl/modelling_qwen3_vl/test_attention.py -v: passed,1 passed, 33 warnings in 1.25s.uv run pre-commit run --all-files: passed.